This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix: major revision to valid and invalid numeric literal separator "sibling" characters #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibling" characters
src/tokenizer/index.js
Outdated
| bin: [ | ||
| // 0 - 1 | ||
| 48, 49, | ||
| ], |
There was a problem hiding this comment.
Nit: I would like to avoid repeating all the numbers... What do you think about doing something like this?
const allowedNumericSeparatorSiblings = {};
allowedNumericSeparatorSiblings.bin = [ 48, 49 ];
allowedNumericSeparatorSiblings.oct = [
...allowedNumericSeparatorSiblings.bin, 50, 51, 52, 53, 54, 55,
];
allowedNumericSeparatorSiblings.dec = [
...allowedNumericSeparatorSiblings.oct, 56, 57,
];It wouldn't have a too big performance impact, since they would be computed only when babylon is loaded.
Anyway, It's up to you.
There was a problem hiding this comment.
Sure, I can do that.
jridgewell
approved these changes
Sep 28, 2017
|
Looks like I have to update to use |
existentialism
approved these changes
Sep 28, 2017
nicolo-ribaudo
approved these changes
Sep 28, 2017
|
@rwaldron Can you fix the linting errors? |
|
Looks nice the way it is, but prettier wants the newlines.. |
|
Thanks @rwaldron!! |
|
Sorry I missed these follow-up messages, I've been afk since Thursday evening. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of testing the Babel transform against NLS tests pending for test262, I discovered a pretty serious oversight in my original parsing. This addresses that issue and adds a substantial amount of tests.